PROPOSAL ONLY (meant to be revised until we agree on it)
Procedure for Commits to the Trunk
With the exception of non-functional and trivial modifications (see below), all commits to trunk should follow this procedure:
- Open a ticket to document the issue the modification addresses
- Attach a patch to the ticket
- Run tests in at least one browser
- Indicate what tests were run where and set ticket state to "Review"
- After a trunk reviewer sets state to "Commit", commit with a message that references the ticket (e.g. "fixed broken code (see #ticketnum).")
Non-Functional Modifications
Commits can be made to the trunk without following the above procedure if the modification falls in to one or more of the categories below:
- Whitespace changes only
- Changes to comments only
- Changes to tests
- Changes to examples
- Change outside of the lib directory
Trivial Modifications
Commits to the trunk can also be made without following the above procedure if the modifications fall in to one or more of the categories below (committer discretion in judging categories here):
- Missing semi-colon or other punctuation
- Changes to code structure to fit CodingStandards
- Obvious typos
