Changes between Version 12 and Version 13 of CreatingPatches

Show
Ignore:
Timestamp:
05/23/12 01:38:16 (12 months ago)
Author:
bartvde
Comment:

change to github

Legend:

Unmodified
Added
Removed
Modified

  • CreatingPatches

    v12 v13  
    1 = How to Create a Patch =  
     1= How to Create a Pull Request (a.k.a. patch) =  
    22 
    33If you have a patch that you wish to be included in the !OpenLayers repository, this is what you need to do: 
    44 
    5  * '''File a Ticket:''' No patches will be made to trunk unless they are accompanied by a trac ticket. For complete instructions:  [wiki:FilingTickets] 
     5 * '''File a Ticket:''' No patches will be made to master unless they are accompanied by an issue, however github automatically creates an issue for you when you create a pull request. For complete instructions:  [wiki:FilingTickets] 
    66 
    77 * '''Read up on our coding standards''': See CodingStandards for guidelines on OpenLayers coding style. 
    … …  
    1111 * '''Write examples''': See the section on [CodingStandards#WritingExamples writing examples] for information on how to write examples demonstrating new functionality (only relevant if your patch introduces new features). 
    1212 
    13  * '''Create the Patch File: '''  
    14    * Get a fresh checkout of trunk. See HowToDownload for information on how to check out the trunk. 
    15    * Make your the modifications for your patch.  
     13 * '''Create the Pull Request: '''  
     14   * Fork OpenLayers under your own github user account 
     15   * Clone your repository 
     16   * Create a branch 
     17   * Make your changes, add them, and then commit them to your branch, followed by a push 
    1618   * Run the tests until they all pass. 
    17    * From a commandline, run {{{ svn diff > yourpatchname.patch }}} to create a patch file.  
    18  
    19  * '''Create a Patch from a Sandbox:''' 
    20    * make sure your sandbox is [wiki:FrequentlyAskedQuestions#Howdoupdatemysandboxfromtrunk up to date] 
    21    * {{{ svn diff http://svn.openlayers.org/trunk/openlayers http://svn.openlayers.org/sandbox/<your sandbox> > yourpatchname.patch }}} 
    22  
    23  * '''Attach Patch to Ticket:''' Click the ''Attach File'' Button under the ''Attachments'' heading and select the {{{ yourpatchname.patch }}} file. 
    24  
    25  * '''Attach new files to Ticket:''' Files you have created as part of your change are not caught by the '''diff''' process. You will have to add these files individually to the patch. 
    26  
    27  * '''Mark Ticket for Review:''' In the ''state'' field of the ticket, select "Review". The !OpenLayers development team regularly runs ticket queries for the keyword "review" to see which tickets are pending. 
    28  
    29 ''For instructions on how to '''apply''' a patch, see ApplyingPatches'' 
     19   * Create a pull request using the github website, see also: [http://help.github.com/send-pull-requests/ pull requests help page]