Ticket #990 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

changeBaseLayer zoom level change

Reported by: crschmidt Owned by:
Priority: major Milestone: 2.5 Release
Component: Map Version: 2.5 RC1
Keywords: Cc:
State:

Description

When you change a base layer, you zoom out. Bart thinks he has a fix, and it seems relatively low cost. Get buy in, and decide whether it goes into 2.5.

Attachments

zoom.patch Download (18.0 KB) - added by tschaub 6 years ago.
fix getZoomForResolution
zoom.2.patch Download (18.5 KB) - added by tschaub 6 years ago.
fix it

Change History

Changed 6 years ago by crschmidt

See last comment to #504.

Changed 6 years ago by tschaub

fix getZoomForResolution

Changed 6 years ago by tschaub

fix it

Changed 6 years ago by tschaub

  • keywords review added

crschmidt kindly pointed out that we can break out of this loop a bit early, assuming the universe and resolutions are ordered. uz kindly pointed out that the overview map tests were fooling IE into thinking there was a problem. Instead of trashing the overview map control entirely, I've changed the tests to fail only if the normalized difference falls below some threshold, keeping us all sane.

Please let this in.

Changed 6 years ago by euzuro

  • keywords commit added; review removed

ALL GOOD MURDOCH. please commit, mark pullup. tests pass ie6 and you say they pass ff.

Changed 6 years ago by tschaub

(In [4381]) New behavior for layer.getZoomForResolution. This method now returns the index of the resolution closest to the passed in resolution - making for fewer unwanted resolution changes, and a generally happier populace (see #990).

Changed 6 years ago by tschaub

  • keywords pullup added; commit removed

With all sorts of warm feelings towards my kind reviewers, I mark this pullup.

Changed 6 years ago by crschmidt

  • keywords pullup removed
  • status changed from new to closed
  • resolution set to fixed

(In [4390]) Pullup changes to trunk for RC2. Includes drag-fires click changes (Closes #982), comment/documentation/requires changes (Closes #983, #993, #988), Fixing post support in proxy.cgi (Closes #991), baseLayer zoom level change (Closes #990), typo in Layer.Image.setURL (Closes #985), and a fix or the Layer.Google bug caused by Google's changing internals (#994). RC2, here we come.

Note: See TracTickets for help on using tickets.