Ticket #980 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

Permalink will keep getting longer

Reported by: crschmidt Owned by: tschaub
Priority: minor Milestone: 2.5 Release
Component: Control.Permalink Version: 2.4
Keywords: Cc:
State:

Description

New permalink code maintains existing parameters ... including the lat/lon/zoom/layers. (Sigh.) This needs to be fixed.

Attachments

ol_permalink.diff Download (2.1 KB) - added by openlayers 6 years ago.
980.patch Download (5.9 KB) - added by sderle 6 years ago.
same patch with bugs fixed and tests added

Change History

Changed 6 years ago by openlayers

Changed 6 years ago by sderle

looks good to me. however, what if the URL has other user-defined stuff in it?

Changed 6 years ago by sderle

same patch with bugs fixed and tests added

Changed 6 years ago by sderle

  • keywords review added

Changed 6 years ago by crschmidt

  • keywords commit added; review removed

I've opened #981, to discuss adding an option for parsing te this.base vs. the URL in the future. For now, I'm going to call this good, and commit it (with fixes to whitespace, cough).

Changed 6 years ago by crschmidt

  • keywords commit removed
  • status changed from new to closed
  • resolution set to fixed

Fixed in r4345.

Note: See TracTickets for help on using tickets.