Ticket #978 (closed task: fixed)

Opened 6 years ago

Last modified 6 years ago

Permalink/Scale throws error if given an element

Reported by: crschmidt Owned by: euzuro
Priority: major Milestone: 2.5 Release
Component: Control.Permalink Version: 2.4
Keywords: Cc:
State:

Description

The Permalink control passes an element as the first parameter, however, the initialize.apply is called with the arguments object, which causes an error if an element is passed into the control.

Attachments

978.patch Download (2.8 KB) - added by crschmidt 6 years ago.

Change History

Changed 6 years ago by crschmidt

Changed 6 years ago by crschmidt

  • keywords review added

Tests pass in FF. Needs to be run in IE

Changed 6 years ago by euzuro

  • keywords commit added; review removed

all tests pass in IE, except for WrapDateline, though I am fairly confident that those test failures are independent of this patch. please commit.

Changed 6 years ago by crschmidt

  • keywords commit removed
  • status changed from new to closed
  • resolution set to fixed

(In [4333]) "The Permalink control passes an element as the first parameter, however, the initialize.apply is called with the arguments object, which causes an error if an element is passed into the control." Also applied to Scale. Now fixed with review from e-dog. (Closes #978) Fixes the only problem I found with migrating the Boston freemap to 2.5.

Note: See TracTickets for help on using tickets.