Ticket #973 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Format.GeoRSS doesn't use Format.XML serializer

Reported by: crschmidt Owned by:
Priority: minor Milestone: 2.5 Release
Component: Format.GeoRSS Version: 2.4
Keywords: Cc:
State:

Description

The format.georss doesn't use the Format.XML serializer. I'd already rewritten a huge chunk of this code so that it worked correctly -- the attached patch is faster, cleaner, and will work in IE.

Note that if this patch is too big, we can instead create a tiny patch to just fix that aspect of the georss format, but it's not particularly useful as it is, so I'd like to get this in.

Attachments

georss.patch Download (19.1 KB) - added by crschmidt 5 years ago.
georss.2.patch Download (22.3 KB) - added by tschaub 5 years ago.
read/write georss

Change History

Changed 5 years ago by crschmidt

Changed 5 years ago by tschaub

read/write georss

Changed 5 years ago by tschaub

check this one - I removed the Util.getNodes functions - and deprecated trim() calls - reworked a few things - added to vector-formats.html

all tests pass in IE/FF

Changed 5 years ago by crschmidt

Looks good to me. Shall I commit?

Changed 5 years ago by tschaub

  • keywords commit added; review removed

commit away!

Changed 5 years ago by crschmidt

  • keywords commit removed
  • status changed from new to closed
  • resolution set to fixed

(In [4305]) Format.GeoRSS didn't use Format.XML serializer, nor did it support reading anything other than points. Both of these are resolved with the new GeoRSS support, which supports all of GeoRSS simple. Includes tests and significant review from Senor Schaub, and addition to the examples/vector-formats.html file. (Closes #973)

Note: See TracTickets for help on using tickets.