Ticket #971 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

dragfeature handler -- drop geometry over another.

Reported by: crschmidt Owned by: tschaub
Priority: minor Milestone: 2.5 Release
Component: Control.DragFeature Version: 2.4
Keywords: Cc:
State:

Description (last modified by crschmidt) (diff)

When you have a polygon feature over a point feature in the same layer, and you attempt to drag the point feature, you get errors about this.feature.geometry being undefined.

Attachments

drag_feature.patch Download (1.6 KB) - added by crschmidt 6 years ago.

Change History

Changed 6 years ago by crschmidt

  • description modified (diff)

Changed 6 years ago by crschmidt

  • summary changed from dragfeature handler -- drag polygon over a point to dragfeature handler -- drop geometry over another.

The problem is more specific than this: the actual problem is when you drag a geometry, *drop* it on another one, then without leaving the bounds of that geometry, try to drag again.

dropping it unsets the feature in doneDragging... but really, I think that we should only remove the feature in outFeature, since we're originally setting it in overFeature.

For the record, doing this also gets rid of the really-annoying flickr when dragging points in the modifyFeature control, so I think I'm on the right track here.

Changed 6 years ago by crschmidt

Changed 6 years ago by crschmidt

  • keywords review added

tests pass in FF - needs to be run in FF, but i expect they'll work there

Changed 6 years ago by crschmidt

Of course, the comment meant 'needs to be run in IE'

Changed 6 years ago by tschaub

  • keywords commit added; review removed

Thanks for catching this Chris. I think this must have crept up with changes to the drag handler (or some other). All looks good, and tests pass in IE. Please commit.

Changed 6 years ago by crschmidt

  • keywords commit removed
  • status changed from new to closed
  • resolution set to fixed

(In [4341]) When you have a polygon feature over a point feature in the same layer, and you attempt to drag the point feature, you get errors about this.feature.geometry being undefined. Fix this by not unsetting this.feature inside the doneDragging. (Closes #971)

Note: See TracTickets for help on using tickets.