Ticket #906 (closed bug: fixed)

Opened 6 years ago

Last modified 5 years ago

Drag.js kills text selection in IE6

Reported by: bartvde Owned by:
Priority: major Milestone: 2.6 Release
Component: general Version: 2.4
Keywords: Cc:
State: Complete

Description

If document.onselectstart is not set, this defaults to null, and applying this to document.onselectstart kills text selection in IE6 after the Drag Handler has been used.

This patch fixes this.

Attachments

drag.patch Download (0.5 KB) - added by bartvde 6 years ago.

Change History

Changed 6 years ago by bartvde

Changed 6 years ago by pgiraud

It seems like there is another ticket related to onselectstart.  http://trac.openlayers.org/ticket/792

Changed 6 years ago by crschmidt

  • milestone set to 2.5 Release

This might already be fixed by #792.

Changed 6 years ago by crschmidt

  • milestone changed from 2.5 Release to 2.6 Release

mismoved.

Changed 5 years ago by bartvde

Hi Chris, we tested with OL 2.5 but this problem still persists. So #792 does not fix this issue.

Changed 5 years ago by crschmidt

  • state set to Needs Discussion

I'm not sure I understand this: What is the default value of onselectstart in IE?

Changed 5 years ago by bartvde

The default value of onselectstart in IE is null.

Changed 5 years ago by crschmidt

  • state changed from Needs Discussion to Review

Changed 5 years ago by crschmidt

  • status changed from new to closed
  • state changed from Review to Complete
  • resolution set to fixed

(In [5911]) Because onselectstart is null by default, our logic to set it and replace it was somewhat lacking. This changes the behavior such that using hte drag handler does not totally disable text selection in IE. Patch from Bart, r=me (Closes #906)

Note: See TracTickets for help on using tickets.