Ticket #894 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

XML parser missing bind for IE

Reported by: tschaub Owned by: tschaub
Priority: minor Milestone: 2.5 Release
Component: Format Version: 2.4
Keywords: Cc:
State:

Description

For IE, the XML format read method was not getting the correct 'this'.

Patch to follow.

Attachments

bind.patch Download (3.7 KB) - added by tschaub 6 years ago.
patch with tests
xmlFormat.patch Download (1.0 KB) - added by euzuro 6 years ago.
Suggested logic modification for tests

Change History

Changed 6 years ago by tschaub

patch with tests

Changed 6 years ago by tschaub

  • keywords review added

Should be an easy review. All tests pass in IE and FF.

Changed 6 years ago by euzuro

  • keywords commit added; review removed

looks good to me. only thing i'd comment on is that this test:

    if(format.xmldom) { 
        t.ok(true, "format only has xmldom in browsers with ActiveX"); 
    } 

doesn't really seem helpful... does it?

Otherwise good to go. All tests pass.

Changed 6 years ago by tschaub

That test is run conditionally - only in browsers with ActiveXObject. The planner is looking for 5 tests in such browsers, 4 in others. If format.xmldom is true in non-ActiveXObject browsers, the tests will fail because they will get 5 instead of 4. Not the most instructive sort of error - but we have to make sure that format.xmldom is not true in non-ActiveX browsers.

Changed 6 years ago by tschaub

  • keywords commit removed
  • status changed from new to closed
  • resolution set to fixed

in w/ r3875

Changed 6 years ago by euzuro

Suggested logic modification for tests

Changed 6 years ago by euzuro

  • keywords reivew added
  • status changed from closed to reopened
  • resolution fixed deleted

I added a new patch that I think makes that xmldom/ActiveXObject bit more clear?

please review.

Changed 6 years ago by tschaub

we really want to test (!window.ActiveXObject format.xmldom)

Changed 6 years ago by euzuro

  • keywords reivew removed
  • status changed from reopened to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.