specify externalGraphic offset

[fredj]

It would be nice if externalGraphic handle offset just like OpenLayers.Layer.Markers does.

Example:

externalGraphic: "my_icon.png",
graphicWidth: 18,
graphicHeight: 26,
graphicYOffset: 0,
graphicXOffset: 9,
fillOpacity: 1

[fredj]

Renderer/VML.js Renderer/SVG.js patch

[elemoine]

Replying to fredj:

New patch based on fredj's. Applies to current SVN. Includes an example of use in vector-features.html. Adds appropriate tests in Layer/test_Vector.html. Tests pass on FF. Could someone run the tests on IE (no w$ handy)?

[elemoine]

new patch based on fredj's (see comment)

[crschmidt]

I'll review this and run tests in IE.

[crschmidt]

Tests pass in IE.

[crschmidt]

Actually, they don't. I've let Eric know what the failure is. (Sorry, I had two copies of OL accidentally and didn't know it.)

[elemoine]

New patch fixing a stupid error in the tests. Still don't know if the tests pass on IE. I'll give it a try myself once I have IE handy.

[crschmidt]

New tests pass in IE now! (Really, this time.)

[fredj]

Thanks for to patch Eric.

The new can patch can cause problem if graphicXOffset or graphicYOffset are set to 0:

var xOffset = style.graphicXOffset || (0.5 * width);

set xOffset to "0.5 * width" because 0 is evaluated as false.

Other problem:

In test_Vector.html, near line 254 the test pass because root.firstChild.getAttributeNS(null, 'x') and (geometryX / renderer.getResolution() + renderer.left) both return NaN.

[crschmidt]

Removing review keyword. Eric, could you prepare a new patch?

Fred, thanks for reviewing this one.

[elemoine]

Replying to fredj:

Thanks for to patch Eric. The new can patch can cause problem if graphicXOffset or graphicYOffset are set to 0: {{{

var xOffset = style.graphicXOffset (0.5 * width); }}} set xOffset to "0.5 * width" because 0 is evaluated as false.

I fixed this by testing whether graphicX|YOffset is undefined or not, in the same way you did in your patch.

Other problem: In test_Vector.html, near line 254 the test pass because root.firstChild.getAttributeNS(null, 'x') and (geometryX / renderer.getResolution() + renderer.left) both return NaN.

Good catch! The problem came from the fact that renderer.setCenter() was never called resulting in renderer.left and renderer.top being not set. I added a map.zoomToMaxExtent() so that renderer.setCenter() gets called.

To be consistent with the way the original marker offset works, I also did this: graphicXOffset must be negative to offset the marker on the left, and graphicYOffset must be negative to offset the marker to the top (and vice versa).

Again, I haven't run the tests on IE, and they'll probably fail. Will do that as soon as I can. I'm posting the patch anyway, for fredj and others to review...

[fredj]

I checked to code on IE and found a problem with graphicYOffset.

With the VML renderer, the y coordinates are flipped so the yOffset have to be flipped too.

To have a 'visual' check, apply the patch and load examples/vector-features.html: the bottom of the red marker (the one on the right) have to be exactly on the green point.

(hope you can understand my poor English)

The following patch fix the problem and the units tests.

(hope that my code is not as bad as my English ...)

[fredj]

Fix the VML problems found in patch-893-A2

[elemoine]

Replying to fredj:

I checked to code on IE and found a problem with graphicYOffset. With the VML renderer, the y coordinates are flipped so the yOffset have to be flipped too. To have a 'visual' check, apply the patch and load examples/vector-features.html: the bottom of the red marker (the one on the right) have to be exactly on the green point. (hope you can understand my poor English) The following patch fix the problem and the units tests. (hope that my code is not as bad as my English ...)

Thanks a lot fredj. The patch looks complete and good now.

[crschmidt]

Erik and I discussed this, and I'm willing to call this one ready -- commit when ready.

[elemoine]

(In [4268]) allow user to specify offsets for externalGraphic (closes #893)