Ticket #881 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

turn 'reproject' to false by default

Reported by: crschmidt Owned by: crschmidt
Priority: critical Milestone: 2.5 Release
Component: Layer Version: 2.4
Keywords: Cc:
State:

Description

the Reproject option on tiles has never worked quite perfectly (because of #429). With the new GoogleMercator layer going into 2.5, we shouldn't be needing this anyway, so turn it *off* by default, so that we don't have to deal with the pain anymore.

Leave the code in until 3.0, when it should probably go away entirely.

Attachments

remove_reproject.patch Download (5.5 KB) - added by crschmidt 6 years ago.
deprecate reproject, and remove from classes where it was never needed

Change History

Changed 6 years ago by euzuro

please also mark that function as Deprecated

Changed 6 years ago by crschmidt

  • status changed from new to assigned

Changed 6 years ago by crschmidt

deprecate reproject, and remove from classes where it was never needed

Changed 6 years ago by crschmidt

  • keywords review added

Changed 6 years ago by euzuro

  • keywords commit added; review removed

patch looks good. my only suggestion would be to remove the property from the WMS layer altogether -- the default 'false' will be picked up since WMS inherits from Grid which inherits from HTTPRequest... no?

all tests pass FF && ie6. please commit

Changed 6 years ago by crschmidt

My goal was to explicitly document it in the docs: people might not meander up to HTTPRequest, but since this is a widely used option, I wanted to explicitly note that the behavior had *changed* as widely as possible.

Thanks for the review.

Changed 6 years ago by crschmidt

  • keywords commit removed
  • status changed from assigned to closed
  • resolution set to fixed

(In [4181]) the Reproject option on tiles has never worked quite perfectly (because of #429). With the new GoogleMercator? layer going into 2.5, we shouldn't be needing this anyway, so turn it *off* by default, so that we don't have to deal with the pain anymore. (Closes #881) Thx to euz for review.

Note: See TracTickets for help on using tickets.