Ticket #875 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

property in global namespace

Reported by: tschaub Owned by: tschaub
Priority: minor Milestone: 2.5 Release
Component: Util Version: 2.4
Keywords: Cc:
State:

Description

Util.extend clobbers the global property variable.

Attachments

property.patch Download (450 bytes) - added by tschaub 6 years ago.
keep variable within the closure
util.patch Download (0.9 KB) - added by crschmidt 6 years ago.
this one has tests

Change History

Changed 6 years ago by tschaub

keep variable within the closure

Changed 6 years ago by tschaub

  • keywords review added

please review

Changed 6 years ago by crschmidt

this one has tests

Changed 6 years ago by crschmidt

  • keywords commit added; review removed

Please commit the patch with a regression test. (Or I can.)

Changed 6 years ago by euzuro

good one guys

Changed 6 years ago by tschaub

  • keywords commit removed
  • status changed from new to closed
  • resolution set to fixed

modified a bit more so the test actually plans on 5 assertions

in w/ r3837

Note: See TracTickets for help on using tickets.