patch to deprecate MapServer.Untiled

[pspencer]

With the introduction of Grid.singleTile, Untiled layers are deprecated. The attached patch does the following:

* modifies MapServer.Untiled to inherit directly from MapServer with a singleTile attribute set to true, and emit a console warning about deprecation (copied from WMS.Untiled directly) * modifies examples/mapserver_untiled.html to use a MapServer layer with a singleTile: true option * modifies tests/Layer/test_MapServer.html to add a useful singleTile test

tests/Layer/test_MapServer_Untiled.html should be removed from trunk as well.

[pspencer]

patch file to update r3815 with changes to support untiled mapserver layers through use of Grid.singleLayer

[tschaub]

Updated the patch to include changes in r3928 (#file2).

Three tests fail in Layer/test_MapServer_Untiled.html. Is this expected? If so, this test page should be removed with this patch.

[crschmidt]

Note that the ticket description does say "tests/Layer/test_MapServer_Untiled.html should be removed from trunk as well."

The tests which are failing are:

• a copy paste error that should never have been tested in the first place (MapServer CGI doesn't use SRS, and the URL is explicitly checking for SRS)
• A change in an internal variable name (but it's not an APIProperty, so we don't care)
• A change to the default ratio value (1 -> 1.5)

So, these tests should be failing -- I guess my only question is whether we should ifx them and merge them into the MapServer.html test file. I think the answer is yes.

For the record, having misbehavior which is tested makes me a sad panda -- it's embarrassing to remove it. I wonder how we can avoid that in the future.

[crschmidt]

merge in tests

[crschmidt]

Move the tests into Layer/test_MapServer.html, and fix the ones that the api change breaks.

Tim -- you said "uploaded a new patch", but I don't see a new patch. Am I missing something? (Also, r3928 only seems slightly related.)

[euzuro]

I apologize for not chiming in on this earlier. I started attacking this ticket but then when I saw that tests were failing I dropped it and got sidetracked. sorry. should have at least added a comment to that effect.

I'll wait on tim putting up the patch he mentions here, and will/can take it over from there if people want. sorry for my negligence.

[tschaub]

Sorry, "Updated the patch" only meant updated on my end, not uploaded.

[crschmidt]

update to trunk

[tschaub]

delete test page and modify test list

[tschaub]

Looks good to me. The mapserver.2.patch modifies list-tests.html so all pass in IE/FF. Please commit.

[crschmidt]

(In [4068]) deprecate MapServer.Untiled in favor of MapServer with singleTile: true. (Closes #866) Thanks for the help to all.