Ticket #835 (closed bug: invalid)

Opened 6 years ago

Last modified 6 years ago

clearMarkers not subclassed properly by boxes layer

Reported by: tschaub Owned by: euzuro
Priority: minor Milestone: 2.5 Release
Component: Layer.Markers Version: 2.4
Keywords: Cc:
State:

Description (last modified by crschmidt) (diff)

clearMarkers only removes markers with icons. As reported by thebigdog on #openlayers, this doesn't treat box markers, and the box layer doesn't override clearMarkers.

Change History

Changed 6 years ago by tschaub

Not sure this is valid - as it looks to me that box markers are really only intended to be used with a box layer.

Anybody else who uses markers want to comment?

Changed 6 years ago by crschmidt

  • description modified (diff)
  • summary changed from clearMarkers should deal with box markers on marker layer to clearMarkers not subclassed properly by boxes layer

Box Markers should only be on a box layer. However, the clearMarkers for the box layer is not overridden from the default, so I'll change the ticket description to be for that instead.

thebigdog: If you're trying to combine boxes and markers, you're probably doing something against design: in fact, the whole of the boxes layer is probably against design at this point, given that we have the vector layer.

Changed 6 years ago by crschmidt

  • status changed from new to closed
  • resolution set to invalid

Looked at the code, and realized that clearMarkers doesn't need subclassing, because it just calls removeMarkers, which is subclassed property, which means that this is, indeed, 'invalid'.

Note: See TracTickets for help on using tickets.