Ticket #800 (closed feature: fixed)

Opened 6 years ago

Last modified 6 years ago

Simplify mergeNewParams() Functionality

Reported by: euzuro Owned by:
Priority: minor Milestone: 2.5 Release
Component: Layer.HTTPRequest Version: 2.4
Keywords: Cc:
State:

Description

Right now everyone has to take care of redrawing themselves on mergeNewParams. This is silly. It should happen automatically. Enter redraw() from #795. Once that patch is approved then all we need to do is call redraw() on the layer after merging in the new params, and each layer will redraw itself accordingly.

Attachments

mergeNewParams.patch Download (2.6 KB) - added by euzuro 6 years ago.
using our favorite new redraw() function, mergeNewParameters() becomes much simpler. Just do the magic at the HTTPRequest level, where it should have been from the start. Lines inserted: 1. Lines deleted: 33. Vive la france!
mergeNewParams.2.patch Download (3.1 KB) - added by euzuro 6 years ago.
sorry. make that one insertion *35* deletions. STAT!
mergeNewParams.3.patch Download (8.6 KB) - added by tschaub 6 years ago.
with a test - includes patch for #795 - apologies

Change History

Changed 6 years ago by euzuro

using our favorite new redraw() function, mergeNewParameters() becomes much simpler. Just do the magic at the HTTPRequest level, where it should have been from the start. Lines inserted: 1. Lines deleted: 33. Vive la france!

Changed 6 years ago by euzuro

  • keywords review added

all tests pass in firefox and ie6. please to reviewing me.

Changed 6 years ago by euzuro

sorry. make that one insertion *35* deletions. STAT!

Changed 6 years ago by tschaub

with a test - includes patch for #795 - apologies

Changed 6 years ago by tschaub

  • keywords commit added; review removed

Very pretty stuff. I added a patch with a test added to see that redraw is called on mergeNewParams. This patch is the whole enchilada #795 (redraw.4.patch) + #800. Don't have time to tease them apart right now.

In any case, I approve.

Changed 6 years ago by euzuro

  • status changed from new to closed
  • resolution set to fixed

thanks again a million for the added test, tim. r3584

Changed 6 years ago by euzuro

  • keywords commit removed
Note: See TracTickets for help on using tickets.