Ticket #772 (closed task: fixed)

Opened 6 years ago

Last modified 6 years ago

Replace $() usage with OpenLayers.Util.getElement()

Reported by: euzuro Owned by:
Priority: minor Milestone: 2.5 Release
Component: general Version: 2.4
Keywords: Cc:
State:

Description

Found a couple of places where this has crept back into the code.

Attachments

getElement.patch Download (5.4 KB) - added by euzuro 6 years ago.
this fixes all the $()s that I could find. Most of them are in the examples but a couple of them in the lib dir as well. I've run tests on FF and IE6 and they pass. Also reasonable passingness on Opera/Mozilla (they break on the same tests as trunk).

Change History

Changed 6 years ago by euzuro

this fixes all the $()s that I could find. Most of them are in the examples but a couple of them in the lib dir as well. I've run tests on FF and IE6 and they pass. Also reasonable passingness on Opera/Mozilla (they break on the same tests as trunk).

Changed 6 years ago by euzuro

  • keywords review added

it might be a good thing to go through and open those examples, make sure they pass. im not familiar with them enough to tell if stuff is working or not. (acceptance tests / examples reform -- hoorah!)

Changed 6 years ago by openlayers

What is the official policy here? I can't find any reference to the rule.

Changed 6 years ago by tschaub

  • keywords commit added; review removed

ok, please commit this - then I'm submitting a patch that gets rid off all occurrences of its use - in favor of document.getElementById - no reason to hide what's going on here - since we are always calling it with one argument

Changed 6 years ago by tschaub

I'd say the rule is to use document.getElementById unless you want to return an array of elements

Changed 6 years ago by euzuro

  • keywords commit removed
  • status changed from new to closed
  • resolution set to fixed

committed with r3626

Note: See TracTickets for help on using tickets.