Ticket #754 (reopened feature)

Opened 6 years ago

Last modified 3 years ago

showPan & showZoomBar options in control PanZoomBar

Reported by: kkempfer Owned by: euzuro
Priority: minor Milestone: 2.13 Release
Component: Control.PanZoomBar Version: SVN
Keywords: Cc: openlayers@…
State: Needs More Work

Description

added two options:

- showPan whether or not to display the pan icons

-showZoomBar whether or not to display the zoom bar

Attachments

panzoombar.patch Download (3.1 KB) - added by kkempfer 6 years ago.
panzoombar.2.patch Download (4.5 KB) - added by kkempfer 6 years ago.
better tests on child divs

Change History

Changed 6 years ago by kkempfer

Changed 6 years ago by kkempfer

  • cc openlayers@… added

Changed 6 years ago by kkempfer

  • keywords review added

Changed 6 years ago by euzuro

this patch looks good, but the test isn't quite thorough enough. the test should actually test for the presence of the divs.

Changed 6 years ago by crschmidt

  • keywords needstests added; review removed
  • milestone set to 2.6 Release

Changed 6 years ago by kkempfer

better tests on child divs

Changed 6 years ago by kkempfer

  • keywords review added

Changed 6 years ago by crschmidt

  • keywords needstests removed

Changed 5 years ago by crschmidt

  • state changed from Review to Needs Discussion

Should this replace the seperate panzoom control, instead just being a wrapper around panzoombar with some set of options?

Changed 5 years ago by crschmidt

  • owner changed from crschmidt to euzuro
  • state changed from Needs Discussion to Review

We'll mark pznaoom as deprecated, but keep it until 3.0, if we pull this in. Erik will review this patch

Changed 5 years ago by euzuro

  • status changed from new to assigned

fwiw, i'm still planning to do this ticket. give me a few days :-)

Changed 5 years ago by crschmidt

  • status changed from assigned to closed
  • state changed from Review to Complete
  • resolution set to fixed

(In [6514]) showPan & showZoomBar options in control PanZoomBar, to turn off the various chunks. In the future, we'll use this to have a single control integrating panzoom and panzoombar, but not quite yet. Revamped patch from kkempfer (thx!) with tests. r=me (Closes #754)

Changed 5 years ago by crschmidt

  • status changed from closed to reopened
  • state changed from Complete to Needs More Work
  • resolution fixed deleted
  • milestone changed from 2.6 Release to 2.7 Release

Removed in r6516: unfortunately, if these options were used, they caused an error in IE when the page unloaded. Since this seems like not a blocker for 2.6, I'm bumping out to 2.7: Anyone anting to revive this should start from r6514, which was updated to work with trunk, rather than the patches attached to this ticket, and concentrate on protecting destroy based on the state of showPan/showZooMBar.

Changed 5 years ago by euzuro

  • milestone changed from 2.7 Release to 2.8 Release

Changed 4 years ago by crschmidt

  • milestone changed from 2.8 Release to 2.9 Release

Not touched since 2.7, moving forward.

Changed 3 years ago by bartvde

  • milestone changed from 2.9 Release to 2.10 Release
Note: See TracTickets for help on using tickets.