Marker.Label

[openlayers]

Using Marker you can add an icon, but not a text/caption/label. This component allows you to add support to it, defining the label and the style to be used. It's recomended to user a negative top to show it on top of the icon (be careful the IE6 does not correctly support it)

[jachym]

I have updated the code to OpenLayers 2.5, run it through jslint. File added. The labels do appear, when mouse over on the icon (can be turned off).

In styles.css, new entry should be added:

.olMarkerLabel {
    font-size: small;
    color: white;
    background-color: darkblue;
    width: auto;
    padding: 1px;
    border: 1px white solid;
    opacity: 0.7;
    z-index: 1000;
}

[jachym]

New version of the file

[jachym]

Other proposed changes:

OpenLayers/Layer/Text.js:

---

data['overflow'] = overflow || "auto";

+ data.label  = title;

OpenLayers/Feature.js:

---

- this.marker = new OpenLayers.Marker(this.lonlat, this.data.icon);

+ if (this.data.label) {
+       this.marker = new OpenLayers.Marker.Label(this.lonlat, this.data.icon, this.data.label,{mouseOver:true});
+ }
+ else {
+      this.marker = new OpenLayers.Marker(this.lonlat, this.data.icon);
+ }

[jachym]

New methods

[jachym]

Tests for OpenLayers.Marker.Label

[jachym]

New file version, tests included.

[crschmidt]

The documentation strings here could definitely use some work: what is 'onlyOnMouseOver' supposed to mean? Also, this isn't right:

92 	     * icon - {<OpenLayers.Icon>}  the icon for this marker
93 	     * lonlat - {<OpenLayers.LonLat>} the position of this marker
94 	     * label - {String} the position of this marker
95 	     * options - {Object}

'label' is not the position of the marker.

An example file with a demonstration is a good idea for this one, and you haven't offered a patch that I can apply. I'm unlikely to review it until there is a patch that applies and adds the:

• Marker/Label.js file
• test file
• Modifies run-tests
• Modifies OpenLayers.js to include Marker/Label.js
• an example via which I can see the output.

[crschmidt]

Mass ticket move to 2.7 post dev meeting. If you are actively working on this task, please update this ticket with information and change the milestone to 2.6. At the time of the next IRC meeting (most likely 1-31-08), this will mean the ticket can *not* be brought back into 2.6 unless there is further feedback.

[crschmidt]

No current/ongoing development work. Moving to Future until someone expresses more interest.

[jachym]

This new addon is no longer needed, because of it can be implemented now using general popups. For example usage, you can use the popupsMatrix example, replace the

marker.events.register("click", feature, markerClick);

line with

marker.events.register("mouseover", feature, markerClick);
marker.events.register("mouseout", feature, markerClick);