Ticket #742 (closed feature: fixed)

Opened 6 years ago

Last modified 6 years ago

Need getControl() / removeControl() functions

Reported by: euzuro Owned by:
Priority: minor Milestone: 2.5 Release
Component: Control Version: SVN
Keywords: Cc:
State:

Description

We have add/get/remove functions for Layers on the map, but we only have add for Controls.

Attachments

controlGetRemove.patch Download (4.2 KB) - added by euzuro 6 years ago.
patch which adds getControl() and removeControl() functionality. Includes tests.
controlGetRemove.2.patch Download (1.8 KB) - added by euzuro 6 years ago.
take two. removeControl() now takes a control instead of an id

Change History

Changed 6 years ago by euzuro

patch which adds getControl() and removeControl() functionality. Includes tests.

Changed 6 years ago by euzuro

  • keywords review added

Changed 6 years ago by sderle

  • keywords commit added; review removed

seems reasonable to me. go ahead and commit.

Changed 6 years ago by euzuro

fixed with r3282. thanks sde!

Changed 6 years ago by euzuro

  • status changed from new to closed
  • resolution set to fixed

Changed 6 years ago by euzuro

  • status changed from closed to reopened
  • resolution fixed deleted

as mentioned by cr5, removeLayer() takes a layer, not an id. removeControl() should do the same.

Changed 6 years ago by euzuro

take two. removeControl() now takes a control instead of an id

Changed 6 years ago by crschmidt

go ahead and commit

Changed 6 years ago by euzuro

  • status changed from reopened to closed
  • resolution set to fixed

fixed with r3329

Changed 6 years ago by euzuro

  • keywords commit removed
Note: See TracTickets for help on using tickets.