Ticket #730 (closed feature: fixed)

Opened 6 years ago

Last modified 6 years ago

The Permalink doesn't respect the existing params

Reported by: penyaskito Owned by: euzuro
Priority: minor Milestone: 2.5 Release
Component: Control.Permalink Version: SVN
Keywords: Cc:
State:

Description

If we have a url with a param, eg: viewmap.php?id=12, the existing param is not respected on the permalink.

Attachments

permalink_querystring.patch Download (3.2 KB) - added by crschmidt 6 years ago.
permalink_querystring.2.patch Download (3.3 KB) - added by euzuro 6 years ago.
two small changes: numbering of tests in test file, and one small code optimization for style/readability

Change History

Changed 6 years ago by penyaskito

Maybe solved with patch attached in #734? Test it.

Changed 6 years ago by crschmidt

Changed 6 years ago by crschmidt

  • keywords review added

Patch with tests, which uses some logic to add to the document.location.href instead of just sticking it in an empty <a> and hoping it will work.

Changed 6 years ago by euzuro

two small changes: numbering of tests in test file, and one small code optimization for style/readability

Changed 6 years ago by euzuro

  • keywords commit added; review removed

good patch chris and good tests. i made a small mod to your patch file, i imagine it won't bother you. please commit.

Changed 6 years ago by crschmidt

  • keywords commit removed
  • status changed from new to closed
  • resolution set to fixed

(In [4047]) (Closes #730) These changes make the permalink smarter in the case where we already have some URL args in the URL. Thanks to penyaskito for the bug report.

Changed 6 years ago by euzuro

  • status changed from closed to reopened
  • resolution fixed deleted

my bad for not properly running tests in IE: 

fail Panning sets permalink. eq:  values differ: got file:///C:/cygwin/home/euzuro/dev/metacarta/openlayers/trunk/tests/Control/test_Permalink.html?lat=0&lon=1.75781&zoom=2&layers=B, but expected ?lat=0&lon=1.75781&zoom=2&layers=B

Changed 6 years ago by euzuro

  • status changed from reopened to closed
  • resolution set to fixed

(In [4054]) remove IE clause from permalink test -- no longer needed. (Closes #730)

Note: See TracTickets for help on using tickets.