Ticket #706 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

Full CSS support fails when Control.OverviewMap is loaded

Reported by: flavour Owned by: tschaub
Priority: minor Milestone: 2.4 Release
Component: Control.OverviewMap Version: 2.4 RC3
Keywords: pullup Cc:
State:

Description

#460 patch/docs work great until a Control.OverviewMap is added to the map.

When this is present then the style.css gets loaded a 2nd time for each div, over-riding both the 1st load (from linked stylesheet) & any custom mods in <HEAD>.

This is clearly visible in Firebug.

(I only tested with the default OverviewMap - i.e. inside the main Map viewport)

Attachments

theme.patch Download (5.1 KB) - added by tschaub 6 years ago.
don't add duplicate link nodes

Change History

Changed 6 years ago by flavour

Here is a workaround: map.addControl(new OpenLayers.Control.OverviewMap({'mapOptions':{'theme':null}}));

<crschmidt> flavour: I don't think I'd ever thought about that. ( Don't know if Tim had.) that should probably be a default.

Changed 6 years ago by tschaub

This is really a problem with the map adding link nodes to the dom when one already exists with an equivalent url. To solve this problem in a more general way, I'm modifying the code that does the theme adding - the following patch only adds one link node per unique theme href and has tests to prove it.

Changed 6 years ago by tschaub

don't add duplicate link nodes

Changed 6 years ago by tschaub

  • keywords review added

my summary: the patch for #460 was incomplete - it sort of allowed for custom themes. this patch completes that functionality (as far as we know right now)

please revieww

Changed 6 years ago by euzuro

  • keywords commit added; review removed

patch looks good to me. let her rip.

Changed 6 years ago by tschaub

  • keywords pullup added; commit removed

resolved with r3153

Changed 6 years ago by crschmidt

  • milestone set to 2.4 Release

Changed 6 years ago by crschmidt

  • status changed from new to closed
  • resolution set to fixed

2.4RC4

Note: See TracTickets for help on using tickets.