Ticket #703 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

OpenLayers.Layer.Vector do not properly destroy its features

Reported by: fredj Owned by: euzuro
Priority: trivial Milestone: 2.4 Release
Component: Memory Management Version: 2.4 RC3
Keywords: pullup Cc:
State:

Description

See patch, specially the HACK HACK comment.

thanks

Attachments

Vector.destroy.js Download (0.6 KB) - added by fredj 6 years ago.
destroyFeatures.patch Download (0.8 KB) - added by euzuro 6 years ago.
only call eraseGeometry() if the feature actually *has* a geometry

Change History

Changed 6 years ago by fredj

Changed 6 years ago by fredj

  • type changed from feature to bug

Changed 6 years ago by crschmidt

  • keywords pullup added; review removed

r3151, for 2.4.

Changed 6 years ago by euzuro

only call eraseGeometry() if the feature actually *has* a geometry

Changed 6 years ago by euzuro

  • keywords review added; pullup removed

i was running tests to approve a patch for tschaub and i was getting script error in the test_Vector.html test. It was due to the patch put in for this ticket, calling a function which isn't fully tested. if the feature has no geometry, the eraseGeometry() function was failing. see destroyFeatures.patch for the fix.

prease review

Changed 6 years ago by euzuro

  • version changed from SVN to 2.4 RC3

Changed 6 years ago by tschaub

  • keywords commit added; review removed

Looks wise. I approve. Please commit. Unless anybody thinks it wiser to put this check in renderer.eraseGeometry().

Changed 6 years ago by euzuro

  • keywords pullup added; commit removed

in with r3155

Changed 6 years ago by crschmidt

  • status changed from new to closed
  • resolution set to fixed

2.4RC4

Note: See TracTickets for help on using tickets.