Ticket #688 (closed feature: wontfix)

Opened 6 years ago

Last modified 5 years ago

Mouse cursor = "wait" on WFS loading

Reported by: fvanderbiest Owned by:
Priority: minor Milestone: 2.7 Release
Component: general Version: SVN
Keywords: Cc:
State: Needs More Work

Description

This patch allows for the change of mouse cursor when it is over the map div. Here, it is used to show a wait cursor on WFS loading.

Attachments

wfs_wait_cursor.diff Download (2.3 KB) - added by fvanderbiest 6 years ago.
patch to get a waiting mouse cursor on wfs loading

Change History

Changed 6 years ago by fvanderbiest

patch to get a waiting mouse cursor on wfs loading

Changed 6 years ago by fvanderbiest

Oups, I noticed a typo in the patch ... You have to replace cursor = 'default' with cursor = 'auto' in the "default" section for the switch in setCursor.

Changed 6 years ago by crschmidt

  • keywords needstests added; review wfs map cursor mouse removed

This patch needs tests: I want to see that if we call 'setCursor', it actually sets it. (The usage of it in the WFS layer is harder to test -- I'm willing to let that one go.)

Changed 6 years ago by tschaub

CSS class names please.

Instead of handling this type of behavior differently in different places - and instead of burying style declarations in the code, I'd like to see this handled with CSS class names.

If we had Util functions for addStyleClass and removeStlyeClass (or some similarly named) - then we could let users (or application developers) decide what they wanted those classes to look like (maybe they want their own cute icons for the cursor). By using multiple class names, we can add a class name that corresponds to just the cursor style - remove that class name and the style returns to the default.

Changed 6 years ago by crschmidt

  • keywords needstests removed
  • milestone changed from 2.5 Release to 2.6 Release

Bumping to 2.6 pending change to use css

Changed 5 years ago by crschmidt

  • state set to Needs More Work

Changed 5 years ago by crschmidt

  • milestone changed from 2.6 Release to 2.7 Release

Mass ticket move to 2.7 post dev meeting.

Changed 5 years ago by tschaub

As Uz kindly reminded me, this deserves the same treatment as #1484 (I believe). Both could use something like  http://trac.openlayers.org/browser/sandbox/topp/almanac/lib/OpenLayers/BaseTypes/Element.js#L126

Will check if there is a ticket for that now. Didn't see one - #1607 now.

Changed 5 years ago by euzuro

  • status changed from new to closed
  • resolution set to wontfix

once #1607 is in, then the correct way to do this will be to listen to the events on the layer (startloading, endloading, or whatever they are called) and then change the map div's class name to be loading (or whatever).

marking as won't fix

Note: See TracTickets for help on using tickets.