Ticket #672 (closed feature: fixed)

Opened 6 years ago

Last modified 6 years ago

Adds maxZoomLevel option for WFS layer

Reported by: fvanderbiest Owned by: euzuro
Priority: minor Milestone: 2.5 Release
Component: Layer.WFS Version: SVN
Keywords: Cc:
State:

Description

This patch adds the ability to load a WFS layer only between some zoom levels. Should be generalized to other types of layer ?

Attachments

wfs_maxZoomLevel.patch Download (0.9 KB) - added by fvanderbiest 6 years ago.
wfs maxZoomLevel
minZoomLevel.patch Download (0.5 KB) - added by euzuro 6 years ago.
you're right, chris. the only place min/max zoom levels should be used is in the FixedZoomLevels descendent layers. Let's remove this.
minZoomLevel.2.patch Download (1.5 KB) - added by euzuro 6 years ago.
instead of removing, deprecate and warn. 3.0 here we come!!!!!

Change History

Changed 6 years ago by fvanderbiest

wfs maxZoomLevel

Changed 6 years ago by crschmidt

  • milestone changed from 2.4 Release to 2.5 Release

Changed 6 years ago by euzuro

  • owner set to euzuro

Changed 6 years ago by crschmidt

The right way to do this is to use scale based rendering -- maxRes/minRes options on the layer, rather than min/max zoom level. (the existing minzoomlevel support was a hack that should have been removed and wasn't.)

Changed 6 years ago by euzuro

you're right, chris. the only place min/max zoom levels should be used is in the FixedZoomLevels descendent layers. Let's remove this.

Changed 6 years ago by euzuro

new patch added. up for review

Changed 6 years ago by crschmidt

  • keywords review removed

I'd like to not remove this functionality, since we're already using it widely (including, I think, in examples). Instead, deprecate this, and in the deprecation warning, include a link to wikipage which documents the right way to do it.

Erik says he'll remake the patch.

Changed 6 years ago by euzuro

instead of removing, deprecate and warn. 3.0 here we come!!!!!

Changed 6 years ago by euzuro

  • keywords review added

tests pass in FF and ie6

Changed 6 years ago by crschmidt

  • keywords commit added; review removed

Checked the warning, it wraps properly in firebug (yay) so this is good to commit.

Changed 6 years ago by euzuro

  • keywords commit removed
  • status changed from new to closed
  • resolution set to fixed

(In [4056]) deprecate use of 'minZoomLevels' in WFS layer. (Closes #672)

Note: See TracTickets for help on using tickets.