Ticket #671 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

Accidental Global Variable usage in Util.js

Reported by: euzuro Owned by:
Priority: blocker Milestone: 2.4 Release
Component: general Version: 2.4 RC1
Keywords: Cc:
State:

Description

*
* @returns A DOM Image created with the specified attributes.
* @type DOMElement
*/
OpenLayers.Util.createImage = function(id, px, sz, imgURL, position, border,
                                       opacity, delayDisplay) {

    image = document.createElement("img");


    //set generic properties
    if (!id) {
        id = OpenLayers.Util.createUniqueID("OpenLayersDiv");
    }

Now how could we have let a thing like that go unnoticed for so long!?

Attachments

image.patch Download (493 bytes) - added by euzuro 6 years ago.
found this through wierd IE testing of OL-based app. thanks IE! :-)

Change History

Changed 6 years ago by euzuro

found this through wierd IE testing of OL-based app. thanks IE! :-)

Changed 6 years ago by crschmidt

  • keywords commit added; review removed

go ahead and commit. this is obvious. and has existed since revision 2 of openlayers! hooray.

Changed 6 years ago by euzuro

  • keywords pullup added; commit removed

fixed with r3086

Changed 6 years ago by crschmidt

  • keywords pullup removed
  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.