Ticket #655 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

layer needs eraseFeatures method

Reported by: tschaub Owned by: tschaub
Priority: minor Milestone: 2.4 Release
Component: Layer Version:
Keywords: Cc:
State:

Description

people shouldn't have to access the layer's renderer to erase features

Attachments

eraseFeatures.patch Download (5.3 KB) - added by tschaub 6 years ago.
adds layer.eraseFeatures

Change History

Changed 6 years ago by tschaub

adds layer.eraseFeatures

Changed 6 years ago by tschaub

  • keywords review added

Ok, I think this is a decent API for 2.4.

If you want to draw something, use layer.drawFeature(). If you want to erase something, use layer.eraseFeatures().

If you are developing a new renderer, note that the renderer superclass has drawFeature and eraseFeatures methods. These are called by the vector layer. In turn, these call drawGeometry and eraseGeometry. Any renderer subclass needs to implement drawGeometry and eraseGeometry. If a renderer subclasses Renderer.Element, these methods are defined there.

Please review.

Changed 6 years ago by crschmidt

  • keywords commit added; review removed

Go ahead for commit, and mark as pullup.

Changed 6 years ago by tschaub

  • keywords pullup added; commit removed

resolved with r3065

Changed 6 years ago by crschmidt

  • keywords pullup removed
  • status changed from new to closed
  • resolution set to fixed

Brought up to 2.4 branch for RC2 with r3088

Note: See TracTickets for help on using tickets.