Ticket #647 (closed task: fixed)

Opened 6 years ago

Last modified 6 years ago

OpenLayers.Tile -- Do not take a 'url' parameter

Reported by: euzuro Owned by:
Priority: minor Milestone: 2.4 Release
Component: Tile Version: 2.4 RC1
Keywords: Cc:
State:

Description (last modified by euzuro) (diff)

As explained in the diff here, there is no reason for the base OpenLayers.Tile class to take an 'url' as a parameter -- that's not its function. let its subclasses do that if they need an url.

Changing this will obviously break the API, so the patch I will suggest will not actually implement this change, but rather adds several poignant "TBD 3.0" comments that we can pick up when we make a major OL revision, as well as adding the code in Tile's two subclasses to make sure they will be ready for the transition (this costs us nothing now)

Note that the real ticket for doing this API change is #648, which is logged under 3.0 Release milestone

Attachments

tiles.patch Download (2.9 KB) - added by euzuro 6 years ago.
add strategic TBD 3.0 comments to remind us to remove the 'url' var from OpenLayers.Tile's constructor.

Change History

Changed 6 years ago by euzuro

add strategic TBD 3.0 comments to remind us to remove the 'url' var from OpenLayers.Tile's constructor.

Changed 6 years ago by euzuro

  • component changed from general to Tile
  • description modified (diff)

Changed 6 years ago by crschmidt

  • keywords pullup added; review removed

Applied in r3034.

Changed 6 years ago by crschmidt

  • keywords pullup removed
  • status changed from new to closed
  • resolution set to fixed

Brought up to 2.4 branch for RC2 with r3088

Note: See TracTickets for help on using tickets.