Ticket #646 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

wfs tile -- no need to pass special args

Reported by: euzuro Owned by:
Priority: minor Milestone: 2.4 Release
Component: Tile.WFS Version: 2.4 RC1
Keywords: Cc:
State:

Description

We used to have to pass special args here because the wfs tile constructor was accepting an array of urls.

It seems that is no longer the case, and so there's no real reason to send a null for url here -- it just makes the code more complicated.

I'll leave the

this.url = url; 

line in there because (see next patch) I am going to propose that the base Tile class shouldn't be dealing with a URL parameter at all (this this assignment will be necessary)

Attachments

wfsTileInit.patch Download (0.6 KB) - added by euzuro 6 years ago.
just pass same 'arguments' to tile constructor -- they are the same

Change History

Changed 6 years ago by euzuro

just pass same 'arguments' to tile constructor -- they are the same

Changed 6 years ago by euzuro

  • type changed from feature to bug

Changed 6 years ago by sderle

  • keywords commit added; review removed

if it doesn't break tests, go ahead

Changed 6 years ago by euzuro

  • keywords pullup added; commit removed

Changed 6 years ago by euzuro

  • component changed from general to Tile.WFS

Changed 6 years ago by crschmidt

  • keywords pullup removed
  • status changed from new to closed
  • resolution set to fixed

Brought up to 2.4 branch for RC2 with r3088

Note: See TracTickets for help on using tickets.