Ticket #632 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

Image Layer broken

Reported by: crschmidt Owned by:
Priority: blocker Milestone: 2.4 Release
Component: Layer.Image Version:
Keywords: pullup Cc:
State:

Description

image-layer.html demo is broken. The image size is set incorrectly. The div it's in is right, but the internal <img> tag is not.

Attachments

imageLayer.patch Download (6.6 KB) - added by tschaub 6 years ago.
fix the image layer

Change History

Changed 6 years ago by tschaub

this was broken by the new gutter stuff (r2979)

I'll include tests in the patch to make sure this doesn't happen again. The upshot is that all layers that use Tile.Image need to set layer.imageSize and layer.tileSize (or else they get the default 256x256) - this is handled by the superclass for most cases - layers that update their tile size with each move need to handle this in moveTo

Changed 6 years ago by tschaub

fix the image layer

Changed 6 years ago by tschaub

  • keywords review added

will commit with review

Changed 6 years ago by crschmidt

Go ahead to commit

Changed 6 years ago by tschaub

  • keywords review removed
  • resolution set to fixed
  • status changed from new to closed
  • component changed from general to Layer.Image

resolved with r3020

Changed 6 years ago by tschaub

(17:10:39) tschaub: ah, guess that should get a pullup instead of resolved

(17:12:32) ***Schuyler shrugs

(17:12:46) Schuyler: before the next RC we'll review what's been added to trunk since the first one

(17:12:50) tschaub: meaning it doesn't matter?

(17:12:52) tschaub: ok

(17:12:55) Schuyler: I don't think so

(17:13:14) Schuyler: I guess what we want to know is if a patch SHOULDN'T be pulled up

(17:13:19) tschaub: right

(17:13:33) tschaub: probably easiest not to accept non-2.4 patches

(17:13:34) Schuyler: maybe we need to re-evaluate the release candidate process

(17:13:42) Schuyler: right, my point exactly

(17:14:05) Schuyler: but if we do that, then why branch the release candidates? why not wait until the release itself to branch

(17:14:12) tschaub: right

(17:14:22) ***Schuyler shrugs

(17:14:27) Schuyler: it doesn't matter so much now

Changed 6 years ago by tschaub

  • keywords pullup added
  • status changed from closed to reopened
  • resolution fixed deleted

Changed 6 years ago by crschmidt

  • status changed from reopened to closed
  • resolution set to fixed

Brought up to branch in r3088.

Note: See TracTickets for help on using tickets.