Ticket #629 (closed feature: fixed)

Opened 6 years ago

Last modified 6 years ago

geometries don't have events

Reported by: tschaub Owned by: tschaub
Priority: minor Milestone: 2.4 Release
Component: general Version:
Keywords: Cc:
State:

Description

creating a new geometry gives you an geometry.events property. This is null, but I think it encourages people to tack on events here. I don't think we want to support this (but I could be wrong).

Currently, these events are only accessed in geometry.destroy() and in the geometry tests.

The following patch gets rid of all trace of geometry.events. I'm open to discussion on leaving this in - perhaps we do want to give people a place to put events, and to have them handled properly on destroy. But since we're not using it now, it seems like a liability to me. Keep in mind that it is not trivial to get at the dom element associated with a rendered feature - so I can't see how people are going to assign listeners to browser events for a geometry that readily.

Attachments

events.patch Download (1.5 KB) - added by tschaub 6 years ago.
get rid of geometry.events

Change History

Changed 6 years ago by tschaub

get rid of geometry.events

Changed 6 years ago by crschmidt

  • keywords commit added

Kill it.

Changed 6 years ago by tschaub

  • keywords commit removed
  • status changed from new to closed
  • resolution set to fixed

killed with r2997

Note: See TracTickets for help on using tickets.