Ticket #567 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

drag handler should only modify onselectstart while dragging

Reported by: tschaub Owned by: tschaub
Priority: minor Milestone: 2.4 Release
Component: general Version:
Keywords: Cc:
State:

Description

Instead of permanently altering onselectstart (the function that turns thing blue in IE6), the drag handler should only modify this behavior while dragging.

The following patch allows you to select things in your document while the drag handler is active (on a page with the navigation control for example). Without the patch, in IE, you can't select anything on the page, ever.

Other modifications include: - browser event handlers always return a value - activate/deactivate pay attention to the return of their parent - some jsdoc text

Attachments

selection.patch Download (5.0 KB) - added by tschaub 6 years ago.
only disable IE selecting while dragging

Change History

Changed 6 years ago by tschaub

only disable IE selecting while dragging

Changed 6 years ago by tschaub

  • keywords review added

have review, will commit

Changed 6 years ago by sderle

  • keywords commit added; review removed

this patch looks good. the only thing I would change would be to add a "oldSelectStart: null" declaration in the Drag class preamble. I say do that and then check it in. I wouldn't bother submitting a new patch if that's all you change.

Changed 6 years ago by tschaub

  • keywords commit removed
  • status changed from new to closed
  • resolution set to fixed

applied in r2908

Note: See TracTickets for help on using tickets.