Ticket #564 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

XHTML Strict DocType breaks editing in IE

Reported by: crschmidt Owned by:
Priority: minor Milestone: 2.4 Release
Component: general Version:
Keywords: Cc:
State:

Description

http://openlayers.org/pipermail/dev/2007-March/000471.html

Reported by Eric Lemoine: 

If you add

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

at the top of examples/editingtoolbar.html, editing behaves strangely:
the geometry displays in the top/left corner as opposed to under the
mouse pointer.

Before 2.4, check if this also breaks zooming in (since the handler control might be at fault here) -- if it does not break zooming/panning, this can be bumped to 2.5 if no patch is created.

Attachments

564.patch Download (1.8 KB) - added by sderle 6 years ago.
changes to VML.js to make it work in IE standards mode; also, change to editingtoolbar.html to exercise the (now fixed) bug

Change History

in reply to: ↑ description   Changed 6 years ago by elemoine

Replying to crschmidt:

http://openlayers.org/pipermail/dev/2007-March/000471.html Reported by Eric Lemoine: {{{ If you add <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" " http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> at the top of examples/editingtoolbar.html, editing behaves strangely: the geometry displays in the top/left corner as opposed to under the mouse pointer. }}} Before 2.4, check if this also breaks zooming in (since the handler control might be at fault here) -- if it does not break zooming/panning, this can be bumped to 2.5 if no patch is created.

Important note: it isn't XHTML Strict per-se that causes the problem, any DOCTYPE line makes the bug trigger.

  Changed 6 years ago by sderle

I think this problem is related to IE's behavior in standards mode, as described in the Google Maps docs:

 http://www.google.com/apis/maps/documentation/#XHTML_and_VML

  Changed 6 years ago by sderle

Fixing this entails two changes to VML.js:

  1. Change the v:group root element to be width: 100% and height: 100% so that it takes up the entire enclosing div element.
  1. Add display: inline-block and position: relative so that VML elements within the group get displayed in the right location. Go figure.

Patch forthcoming.

Changed 6 years ago by sderle

changes to VML.js to make it work in IE standards mode; also, change to editingtoolbar.html to exercise the (now fixed) bug

  Changed 6 years ago by sderle

BTW, editingtoolbar.html still works in FF and in IE quirks mode with these changes.

  Changed 6 years ago by sderle

  • keywords review added

  Changed 6 years ago by crschmidt

Go ahead to commit.

  Changed 6 years ago by sderle

  • status changed from new to closed
  • resolution set to fixed

fixed by r2959

  Changed 6 years ago by euzuro

  • keywords review removed
Note: See TracTickets for help on using tickets.