Ticket #514 (closed feature: fixed)

Opened 6 years ago

Last modified 6 years ago

Safari: getCurrentSize fails on display:none elements

Reported by: crschmidt Owned by: crschmidt
Priority: major Milestone: 2.4 Release
Component: general Version: SVN
Keywords: Cc:
State:

Description

Elements with display:none set will fail to return the correct value for getCurrentSize in Safari. Hidden elements return 'NaN' for clientWidth (as opposed to '0' from other browsers) so the fallback logic in getCurrentSize is never executed. The Overview Map not working in Safari is a symptom of this bug: because the overview map element is created as display:none, the map has 0 size on creation, and is therefore not displayed correctly.

Confirmed with svn r2301.

Attachments

safari.patch Download (2.0 KB) - added by crschmidt 6 years ago.
Fix getCurrentSize for hidden elements in safari

Change History

Changed 6 years ago by crschmidt

Fix getCurrentSize for hidden elements in safari

Changed 6 years ago by crschmidt

  • keywords review added

Attached patch includes getCurrentSize fix. It also includes a standalone test file. Because our current test framework does not handle safari, this file is not integrated into the existing framework, but instead implements a a single regression test, while allowing for the addition of other safari-only breakages to the file.

Changed 6 years ago by sderle

  • status changed from new to closed
  • resolution set to fixed

Applied as r2206.

Changed 6 years ago by euzuro

  • keywords review removed
Note: See TracTickets for help on using tickets.