Layer.Text markers show a popup even if no popup text is set

[openlayers]

When using Layer.Text, if the text file does not contain description or title for a popup to appear on click of the marker, a popup is still applied. This results in a popup appearing with no obvious way to close it.

OpenLayers\Layer\Text.js should first check on line 129 if title and description is not null before assigning the onClick handler.

[danielm]

Changes the text layer so if title and description is null then the marker onClick event is not set. This makes the unit tests fail though cause they are expecting the onClick handler.

[crschmidt]

danielm: an update to the tests to include one item which has an onclick and one that doesn't, and adjusting the responses to fit that, would make me happier about this. If you can add that, I'll apply/review/commit.

[crschmidt]

same as other patch, adds tests for both cases

[crschmidt]

New patch updates tests, awaiting review.

[sderle]

07:12 < Schuyler> on #471, is it possible that a user might want to render a

popup with either a title or a description, even if the other one is missing?

07:13 < crschmidt> yes 07:13 < crschmidt> I'd say that "&&" should be an

[sderle]

that should be "pipe pipe" ... darn Trac

[crschmidt]

Patch is good in my eyes.

[sderle]

For reasons that aren't clear, my patch causes horrible test failures. Rather than continue to fight with this, I'm going to commit Chris's patch instead and move on.

Fixed by r2820.