Ticket #42 (closed feature: fixed)

Opened 7 years ago

Last modified 6 years ago

Finish Control.KeyboardDefaults

Reported by: sderle Owned by: crschmidt
Priority: critical Milestone: 2.4 Release
Component: Control.KeyboardDefaults Version:
Keywords: Cc:
State:

Description

Chris says it works, but because keyboard events apparently always happen on the document level, we need to figure out how to have them only happen when you're 'focused' on the map, and then have them on by default.

Attachments

keyboard.patch Download (1.3 KB) - added by crschmidt 6 years ago.
keyboard.2.patch Download (1.1 KB) - added by crschmidt 6 years ago.

Change History

Changed 7 years ago by sderle

  • priority changed from minor to blocker

Changed 7 years ago by sderle

see also #44, as these two tickets are linked

Changed 7 years ago by crschmidt

  • milestone changed from Cambridgeport to Dubo River

This isn't actually tied to #44, which can be done seperately. #44 is a blocker for MetaCarta usage, but this is not. Moving to Dubo River.

Changed 7 years ago by crschmidt

  • milestone changed from Dubo River to Esfahan

This is cool, but not crucial. Bumping in hopes of getting it done for a 2.1 or 2.2 release.

Changed 7 years ago by euzuro

  • milestone 2.1 Release deleted

Changed 7 years ago by sderle

  • priority changed from blocker to critical
  • milestone set to 2.3 Release

Changed 7 years ago by euzuro

  • component changed from Control to Control.KeyboardDefaults

Changed 7 years ago by crschmidt

So, since I wrote this code, I've learned that the other APIs -- VE, Google, etc. -- don't actually have keyboard controls in their APIs, only in their main map pages. This means that solving the problem of only moving the map via the keyboard is probably not a problem that needs to be solved.

However, for some reason, once you hit a key, the keyboard control latches onto it, and it doesn't let go. So, that bug needs to be fixed. I don't remember this being the case in the past.

Changed 6 years ago by crschmidt

  • status changed from new to assigned

Mine for 2.3.

Changed 6 years ago by euzuro

  • milestone changed from 2.3 Release to 2.4 Release

Changed 6 years ago by crschmidt

Changed 6 years ago by crschmidt

Changed 6 years ago by crschmidt

  • keywords review added

Keyboard.2.patch fixes the KeyboardEvents file, and adds support for using pageup/+ to zoom in and pagedown/- to zoom out.

Changed 6 years ago by sderle

  • status changed from assigned to closed
  • resolution set to fixed

Fixed by r2540.

Changed 6 years ago by euzuro

  • keywords review removed
Note: See TracTickets for help on using tickets.