Ticket #385 (closed feature: fixed)

Opened 7 years ago

Last modified 6 years ago

building for windows users

Reported by: tschaub Owned by: sderle
Priority: minor Milestone: 2.3 Release
Component: general Version: 2.3 RC1
Keywords: Cc:
State:

Description

Think this ticket is captured elsewhere, but I couldn't identify exactly where. I know the real solution is to have a pure python build script, but to satisfy any windows users in the meantime, I've put together a quick batch script. This requires one simple change to tools/mergejs.py.

The mergejs.py change might make sense to incorporate anyway. I didn't take time to track it down, but it seems that toposort produces some / delimited paths. In any case, everything works if you treat all paths as / delimited - including in the cfg file.

Since I've been a little patch happy lately, I thought I'd hold off. If anybody is interested in the changes, they're in r1747.

In addition to the one line addition in mergejs.py, I've replaced a few tabs with spaces.

No guarantees, but works for me.

Attachments

license_build.patch Download (0.6 KB) - added by tschaub 6 years ago.
patch to build with license

Change History

Changed 7 years ago by sderle

  • owner set to sderle
  • status changed from new to assigned

Changed 7 years ago by tschaub

In case the above is too cryptic, Windows users can build with this batch script:  http://trac.openlayers.org/browser/sandbox/tschaub/wc/build/build.bat

And the one line addition to mergejs.py shown in r1747.

Until you've got the pure python build worked out, this might be a suitable alternative.

Changed 6 years ago by euzuro

  • milestone set to 2.3 Release

Changed 6 years ago by sderle

  • status changed from assigned to closed
  • resolution set to fixed

Fixed by r2097 and r2098.

Changed 6 years ago by tschaub

  • status changed from closed to reopened
  • resolution fixed deleted

jsmin strips out the license file - patch to follow

Changed 6 years ago by tschaub

patch to build with license

Changed 6 years ago by tschaub

  • keywords review added

happy to commit if reviewed - note this applies to all users, not just windows users

Changed 6 years ago by euzuro

  • keywords review removed
  • version set to 2.3 RC1

nice one tim :-)

I'm marking the version on this 2.3 RC1

Please go ahead and apply this patch in trunk, mark ticket as pullup.

Changed 6 years ago by tschaub

  • keywords pullup added

applied in r2126

Changed 6 years ago by crschmidt

  • keywords pullup removed
  • status changed from reopened to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.