Custom id on layer skip some initialization

[gnafu]

Setting layer id for a WMS layer causes an error. Issue detected 1 year ago, never resolved.  http://comments.gmane.org/gmane.comp.gis.openlayers.user/16912

If the id is passed when creating the layer the code skip the this.events initialization.

Maybe it's a simple typo, a closed brace at the wrong line. Patch attached.

[gnafu]

Patch for ticket #3650

[erilem]

I also cannot make sense of the current code, and the attached patch looks good to me. But this sounds suspicious—there must be a reason to the current logic. Does anyone have a clue?

[vmische]

Perhaps it helps to know which commit introduced it:  http://trac.osgeo.org/openlayers/changeset/3035

[erilem]

Thanks vmische. So this has to do with calling the Layer constructor twice in case of multiple inheritance. But there must be a better way to deal with that. Maybe gnafu's patch + checking if the div was already created.