Ticket #3519 (closed feature: fixed)

Opened 21 months ago

Last modified 18 months ago

build.py -c closure: Show file name and line number of errors and warnings.

Reported by: jorix Owned by:
Priority: minor Milestone: 2.12 Release
Component: general Version: 2.11
Keywords: build closure Cc:
State: Complete

Description

When errors or warnings from compilation is more comfortable to see directly where they are produced. Currently must guess the location of the errors using OpenLayers.js obtained by build.py -c none.

To obtain this feature is necessary pass to the compiler a list of filenames instead of the merged file.

The implementation proposes to use  jscompiler.py used in the Closure Library. Changes are proposed in mergejs.py so can return a merged file or a list of files, but has remained the same code for the selection and determine order of source files. There are also changes in build.py

Attachments

3519.patch Download (8.7 KB) - added by jorix 21 months ago.

Change History

Changed 21 months ago by jorix

Changed 21 months ago by jorix

  • state set to Review

Changed 19 months ago by jorix

Please review this pull request:

 https://github.com/openlayers/openlayers/pull/49

Tested on: Windows XP+python2.4, Vista+python2.7 and Ubuntu10+python2.6

Changed 19 months ago by jorix

Please review:

 https://github.com/openlayers/openlayers/pull/91

This pull request replaces the  #49 that had many commits.

Changed 18 months ago by jorix

  • status changed from new to closed
  • state changed from Review to Complete
  • resolution set to fixed
Note: See TracTickets for help on using tickets.