Ticket #3496 (closed feature: fixed)

Opened 22 months ago

Last modified 17 months ago

Build: Skip the required files if they are excluded.

Reported by: jorix Owned by:
Priority: minor Milestone: 2.12 Release
Component: general Version: SVN
Keywords: build merge mergejs exclude Cc:
State: Complete

Description

There are some source files that are only required if default values are used, for example:

  • Using new OpenLayers.Map(..., {panMethod: null, ...}); then OpenLayers/Tween.js is not required
  • Using new OpenLayers.Control.LayerSwitcher({roundedCorner: false}); then Rico/Corner.js is not required

But it is not possible to exclude these files using the [exclude] clause in the configuration files. The file is always included if file name is in @requires into an other source file.

The patch proposes changes in mergejs.py to take into account the [exclude] clause to exclude also the required files.

Attachments

3496.patch Download (2.3 KB) - added by jorix 22 months ago.
3496.1.patch Download (2.3 KB) - added by jorix 21 months ago.

Change History

Changed 22 months ago by jorix

Changed 22 months ago by jorix

  • state set to Review

Changed 21 months ago by jorix

  • state changed from Review to Needs More Work

This solution does not work for directory exclusion. I'll work some more...

Changed 21 months ago by jorix

Changed 21 months ago by jorix

  • state changed from Needs More Work to Review

3496.patch Download works (I had a problem when combined with another patch that I am studying)

I have prepared 3496.1.patch Download that creates a cache for _getRequirement, but two patches give the same results.

Please review.

Changed 17 months ago by tschaub

  • status changed from new to closed
  • state changed from Review to Complete
  • resolution set to fixed
Note: See TracTickets for help on using tickets.