Ticket #3470 (closed feature: fixed)

Opened 22 months ago

Last modified 22 months ago

OpenLayers.Layer.HTTPRequest initialize simplification

Reported by: fredj Owned by:
Priority: trivial Milestone: 2.11 Release
Component: general Version: SVN
Keywords: Cc:
State: Pullup

Description

in initialize we currently have:

initialize: function(name, url, params, options) {
  var newArguments = arguments;
  newArguments = [name, options];
  OpenLayers.Layer.prototype.initialize.apply(this, newArguments);
  ...

could it be replaced with:

initialize: function(name, url, params, options) {
  OpenLayers.Layer.prototype.initialize.apply(this, [name, options]);
  ...

or do I miss something?

Change History

Changed 22 months ago by erilem

  • state changed from Review to Commit
  • milestone changed from 2.12 Release to 2.11 Release

Looks good to me. I think this can safely go in 2.11.

Changed 22 months ago by fredj

  • state changed from Commit to Pullup

Changed 22 months ago by crschmidt

  • status changed from new to closed
  • resolution set to fixed

(In [12274]) Pulling in patches for OL 2.11 RC3:

  • ArcGISCache resolutions get compromised by some JS frameworks. (Closes #3474)
  • OpenLayers.Layer.HTTPRequest initialize simplification (Closes #3470)
  • missing requires (Closes #3467)
  • deleting a vertex does not update feature.modified (Closes #3463)
  • fixing test failure in some browsers (Closes #3461)
  • a grid layer may be moved while its grid hasn't been initialized yet (Closes #3458) -- this one is the actual release blocker
  • Change the callback function of Protocol.Script (JSONP) (Closes #3417)
  • "build.py -c closure" does not work on Windows systems. (Closes #3158)
Note: See TracTickets for help on using tickets.