Ticket #3458 (closed bug: fixed)

Opened 22 months ago

Last modified 21 months ago

a grid layer may be moved while its grid hasn't been initialized yet

Reported by: erilem Owned by: elemoine
Priority: blocker Milestone: 2.11 Release
Component: Layer.Grid Version: 2.11 RC1
Keywords: Cc:
State: Pullup

Description

... leading to this.grid[0] is undefined when the map is panned.

This is a critical regression.

To reproduce:

  • open  http://www.openlayers.org/dev/examples/wms.html
  • in the FB console create an out-of-range grid layer, and add it to the map
     grid = new OpenLayers.Layer.WMS('grid', 'http://example.com', {}, {isBaseLayer: false, minResolution: 2});
     map.addLayer(grid);
    
  • pan the map -> this.grid[0] is undefined

Test and patch to come.

Attachments

patch-3458-A0.diff Download (4.4 KB) - added by erilem 22 months ago.

Change History

Changed 22 months ago by erilem

Changed 22 months ago by erilem

  • state set to Review
  • type changed from feature to bug

patch-3458-A0.diff Download fixes it. Please review.

Changed 22 months ago by ahocevar

  • state changed from Review to Commit

Thanks for fixing this @erilem. The solution makes perfect sense, as it does basically the same preliminary check that is done in moveTo (visibility, inRange, and special treatment for base layers). Please commit.

Changed 22 months ago by erilem

(In [12236]) a grid layer may be moved while its grid hasn't been initialized yet, r=ahocevar (references #3458)

Changed 22 months ago by erilem

  • state changed from Commit to Pullup

Changed 21 months ago by crschmidt

  • status changed from new to closed
  • resolution set to fixed

(In [12274]) Pulling in patches for OL 2.11 RC3:

  • ArcGISCache resolutions get compromised by some JS frameworks. (Closes #3474)
  • OpenLayers.Layer.HTTPRequest initialize simplification (Closes #3470)
  • missing requires (Closes #3467)
  • deleting a vertex does not update feature.modified (Closes #3463)
  • fixing test failure in some browsers (Closes #3461)
  • a grid layer may be moved while its grid hasn't been initialized yet (Closes #3458) -- this one is the actual release blocker
  • Change the callback function of Protocol.Script (JSONP) (Closes #3417)
  • "build.py -c closure" does not work on Windows systems. (Closes #3158)
Note: See TracTickets for help on using tickets.