Ticket #3448 (closed bug: fixed)

Opened 22 months ago

Last modified 19 months ago

OpenLayers.Format.WPSExecute fails with WFS references

Reported by: adamratcliffe Owned by: bartvde
Priority: minor Milestone: 2.12 Release
Component: Format.WPSExecute Version: SVN
Keywords: wps Cc: adam@…
State: Commit

Description

WPSExecute currently augments its writer functions with the WFS v1.1.0 functions but does not inherit from OpenLayers.Format.WFST.v1_1_0 the helper functions called by those writer function. The attached patch corrects this problem.

Attachments

wpsexecute.patch Download (1.5 KB) - added by adamratcliffe 22 months ago.
WPSExecute patch
openlayers-3448.patch Download (1.2 KB) - added by ahocevar 22 months ago.
WPSExecute.html Download (2.9 KB) - added by adamratcliffe 21 months ago.
Test Case
ol-3448.patch Download (7.3 KB) - added by bartvde 21 months ago.
new patch that includes the testcase and makes it pass, starting off from ahocevar's original patch

Change History

Changed 22 months ago by adamratcliffe

WPSExecute patch

Changed 22 months ago by erilem

adamratcliffe, do we have a CLA from you? Thanks.

Changed 22 months ago by ahocevar

Changed 22 months ago by ahocevar

  • state set to Awaiting User Feedback

@adamratcliffe: Can you please test if openlayers-3448.patch Download solves the problem for you? Also, it would be great if you could provide a test case that shows the issue. If you are not familiar with our test framework, I'd also accept a minimal html page that shows the issue, so I can turn it into a test case.

Changed 22 months ago by crschmidt

  • milestone changed from 2.11 Release to 2.12 Release

Changed 21 months ago by adamratcliffe

@ahocevar I've tested  openlayers-3448.patch and it doesn't appear to solve the problem that my patch addresses, adding the helper functions from OpenLayers.Format.WFST.v1_1_0 to OpenLayers.Format.WPSExecute.

I've attached a test case that demonstrates the issue. I followed the example of some of the existing framework test cases but wasn't quite sure how to run the test so it may not be entirely correct.

Changed 21 months ago by adamratcliffe

Test Case

Changed 21 months ago by bartvde

new patch that includes the testcase and makes it pass, starting off from ahocevar's original patch

Changed 21 months ago by bartvde

  • state changed from Awaiting User Feedback to Review

Relevant tests pass in FF5 and IE8, TIA for any review.

Changed 19 months ago by ahocevar

  • state changed from Review to Commit

Thanks for the added tests Bart. Please commit.

Changed 19 months ago by bartvde

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.