Fix OpenLayers.Renderer.Canvas.drawFeature method in case if feature's bounds are empty

[arublev]

See  https://github.com/openlayers/openlayers/pull/21

[fredj]

looks good to go: this check is missing for Renderer.Canvas but already done for Renderer (see source:trunk/openlayers/lib/OpenLayers/Renderer.js#L181)

[erilem]

Replying to fredj:

looks good to go: this check is missing for Renderer.Canvas but already done for Renderer (see source:trunk/openlayers/lib/OpenLayers/Renderer.js#L181)

Fredj, could do write a quick test for that before commit? If you have no time, I'll do it. Thanks.

[fredj]

adding unit tests

[fredj]

attachment:"3442.1.patch" adds units tests (using a Polygon geometry with no coordinates: new OpenLayers.Geometry.Polygon().getBounds() returns null).

I've also updated the test in drawFeature: instead of:

rendered = (style.display !== "none") && bounds && bounds.intersectsBounds(this.extent)

it's now:

rendered = !!(style.display !== "none" && bounds && bounds.intersectsBounds(this.extent))

because if bounds is null, rendered equals null.

A side effect of writing unit tests: finding bugs :-)

[erilem]

For clarity I'd rather do

rendered = (style.display !== "none") && !!bounds && bounds.intersectsBounds(this.extent);

With that we make it explicit what element we need to cast to a boolean.

Please commit with the statement you like most.

[fredj]

Replying to erilem:

For clarity I'd rather do {{{ rendered = (style.display !== "none") && !!bounds && bounds.intersectsBounds(this.extent); }}} With that we make it explicit what element we need to cast to a boolean. Please commit with the statement you like most.

your version is is more clear, thanks

[fredj]

(In [12205]) handle features with null bounds in OpenLayers.Renderer.Canvas.drawFeature. p=arublev,me r=erilem (closes #3442)

[ahocevar]

in 2.11-rc2