Ticket #3436 (closed bug: fixed)

Opened 22 months ago

Last modified 22 months ago

not possible to add a geometry to a feature and issue a transaction

Reported by: bartvde Owned by: tschaub
Priority: minor Milestone: 2.12 Release
Component: Format.WFST Version: 2.10
Keywords: Cc:
State: Commit

Description

Currently the following situation can not be accomplished: having a feature without a geometry, and then adding a geometry using the DrawFeature Control and issuing a WFS transaction. No transaction will be fired, since we check for a truthy modified.geometry.

Attachments

ol-3436.patch Download (3.6 KB) - added by bartvde 22 months ago.
updated patch that takes into account null attributes as well
openlayers-3436.patch Download (3.6 KB) - added by ahocevar 22 months ago.
like above, but with minor modifications in the tests and APIdocs

Change History

Changed 22 months ago by bartvde

  • state set to Review

Relevant tests pass in FF 5 and Safari 5.1, TIA for any review.

Changed 22 months ago by bartvde

updated patch that takes into account null attributes as well

Changed 22 months ago by ahocevar

like above, but with minor modifications in the tests and APIdocs

Changed 22 months ago by ahocevar

  • state changed from Review to Commit

Confirming that tests pass in Safari5. Please commit if you agree with my changes.

Changed 22 months ago by bartvde

  • status changed from new to closed
  • resolution set to fixed

(In [12188]) modified checks for Format.WFST should use not equal to undefined instead of truthy to deal properly with initial null values, r=ahocevar (closes #3436)

Note: See TracTickets for help on using tickets.