Modifying point features does not stop at mouseup

[ahocevar]

To reproduce:

1. Open http://openlayers.org/dev/examples/modify-feature.html
2. Select "draw point" and draw a point
3. Select "modify feature"
4. Click the point to select it. After mouseup, move the mouse to somewhere else.
5. Click and drag the point. Dragging will not stop on mouseup.

This is a regression from 2.10.

[ahocevar]

This regression is caused by r11845.

[ahocevar]

The attached patch makes the workflow in the ticket description work as expected again. All tests still pass (but I don't know how to write a unit test assertion that shows the problem that the patch fixes). Thanks for any review.

[jorix]

Replying to ahocevar:

The attached patch makes the workflow in the ticket description work as expected again. All tests still pass (but I don't know how to write a unit test assertion that shows the problem that the patch fixes). Thanks for any review.

Hi ahocevar,

I investigated about this issue.

There is another problem, try:

• Starting and stopping drag of a point (or vertex of a line or polygon).
• mousedown and mouseup (without moving the mouse)
• mousemove, oops! point moves

openlayers-3428.patch does not solve this second problem. But openlayers-3428.patch adds a behavior that may be interesting to drag a point without prior selection.

And I think there is another way to fix the bug without using setTimeout. r11845 added the methods clickFeature and clickoutFeature but only for the management of the touch events. So it may condition its use only for this case and this fixes both problems.
See 3428.B1.patch

[ahocevar]

@jorix: what you're doing in 3428.B1.patch was my first attempt to fix the issue as well, but it breaks the modify-feature.html example on iOS.

[ahocevar]

Hm. Tested jorix's patch now on both Safari5 (Mac), Safari (iOS Simulator) and Android 2.1, and it seems to fix the issue indeed. Must have been a caching issue on my end when I tested this first. Thanks jorix for the fix!

[ahocevar]

(In [12181]) click handling in the DragFeature control only for touch devices. p=jorix, r=me (closes #3428)

[jorix]

NOTE: After r12181 #3398 no longer fails, I closed as a duplicate.

[ahocevar]

in 2.11-rc2