Correct Longitude when Wrapping Dateline

[cayenne]

The getFormattedLatLon function works fine except in the vicinity of a dateline wrap. Then it displays spurious values like 215E.

This can be fixed with a minor change to the routine using addition, subtraction, and modulo. It might be more efficient to use an "if>180" test, but my revised code works.

[tschaub]

ICLA  received. Thanks.

[ahocevar]

@cayenne: Thanks a lot for your contribution. Please provide patches for improvements you want to contribute. See CreatingPatches for instructions.

[cayenne]

@ahocevar

Okay, I will do so. I'll need to learn yet another system, but that's part of the fun.

It's just a single line, but I'll go learn the patch process for svn.

coordinate = (coordinate+540)%360 - 180; // normalize for sphere wraparound

[cayenne]

Patch added. That was not too hard to learn!

[ahocevar]

(In [12172]) fixing dateline handling of Util.getFormattedLonLat. p=cayenne, r=me (closes #3411)

[ahocevar]

Thanks @cayenne for taking the time to create the patch. Great work. I added two simple assertions to the test suite. Now that you already know how to create patches, maybe your next patch will even come with some test coverage.

[cayenne]

Thanks to YOU, @ahocevar

Yes, before submitting my next one (geographically corrected polygons), I will learn the test process. Is there a tutorial for that?

[ahocevar]

Replying to cayenne:

Yes, before submitting my next one (geographically corrected polygons),

Check #2787 first, there may already be a fix, but the patches there lack tests as well.

I will learn the test process. Is there a tutorial for that?

Unfortunately not. At least none that I'm aware of.