Option to always write Multi geometries

[ahocevar]

In the DrawFeature control, we have a multi option to make sure that the geometries we create are MultiPoint, MultiLineString or MultiPolygon geometries. In a WFS context, it may be necessary to always write Multi geometries, even if they were read as plain geometries. This ticket suggests adding a multi option to the WFST format's write method.

[ahocevar]

Tests pass in Safari5. Thanks for any review.

[bartvde]

Hi Andreas, one minor issue: geometry is missing var keyword. Respective tests also pass in FF5. Please commit.

[ahocevar]

(In [12168]) giving the WFST format a multi option, which makes sure that Multi geometries are written in transactions. r=bartvde (closes #3407)

[ahocevar]

Please consider this improvement. Tests pass in Safari5. Thanks for any review.

[ahocevar]

nicer approach using the GML format's geometryTypes mapping

[bartvde]

Hey Andreas, a few remarks:

• using your current patch I cannot create a multi mapping for only lines for instance. Can we allow people to define their own multiGeometryTypes?
• can we avoid expressions with side effects on the right side of logical operators? ( http://docstore.mik.ua/orelly/webprog/jscript/ch05_07.htm) This also avoids jslint warnings.
• I have a failing test in FF5: test_write_multi planned 2 assertions but got 0; fail 0 ok 0, exception: : object: this.writers[prefix][local] is undefined

[ahocevar]

Thanks Bart for the review. Replying to bartvde:

* using your current patch I cannot create a multi mapping for only lines for instance. Can we allow people to define their own multiGeometryTypes?

This also is not possible with the current solution, so I'd suggest making a new ticket for this if it is needed.

* can we avoid expressions with side effects on the right side of logical operators? ( http://docstore.mik.ua/orelly/webprog/jscript/ch05_07.htm) This also avoids jslint warnings.

No such expression was in the previous patch, but I'm using a different approach in the new one which I hope you like better :-).

* I have a failing test in FF5: test_write_multi planned 2 assertions but got 0; fail 0 ok 0, exception: : object: this.writers[prefix][local] is undefined

Hm. Never underestimate the power of the browser cache. You are right, the tests failed for me as well. In fact this approach requires more changes.

New patch attached, tests now really pass. Thanks for another review.

[bartvde]

Hey Andreas,

this is good to go now, thanks for the work on this, 2 remarks:

• some of the for loops miss the use of var len
• I still get jslint errors on some of the code, e.g.:

options.multi === true && this.setGeometryTypes();

gives: Expected an assignment or function call and instead saw an expression.

why not just use:

if (options.multi === true) {
    this.setGeometryTypes();
}

?

[ahocevar]

Thanks Bart for the continued reviewing efforts. I'll remove the ternary operator without assignment use and replace it with if statements. But regarding the len, I haven't changed any of the loops, and var len is properly defined above the first loop that uses it.

[ahocevar]

Bart, thanks for the explanation on IRC. Although these loops were not optimized before my patch, I'm going to optimize them before I commit.

[ahocevar]

final patch, incorporates all review comments.

[ahocevar]

(In [12171]) reassign writers instead of creating a different geometry instance. r=bartvde (closes #3407)