Dragging over controls ends drag sequence

[ahocevar]

In OpenLayers 2.10, any drag operation (e.g. creating a zoombox and moving it over the PanZoom control) used to continue. Now it does not any more, because of the new eventsDiv.

This ticket suggests setting documentDrag to true by default on the Drag handler and all controls that use it. This does not only solve the issue, but makes map interaction more intuitive when working close to the viewport edges.

[ahocevar]

All tests pass in Safari5, examples work as expected. Thanks for any review.

[erilem]

I'd like to verify that setting documentDrag to true doesn't cause any performance issue on mobile.

[jorix]

Sounds like a great idea, so I worked a bit again in OL doing some tests and patchs.

Some observations:

• Default value in the documentation.
• Maintaining the appearance of the cursor outside the map, see #3371 & #3372
• Error JS in Handler.RegularPolygon, see #3373
• It would be interesting to have documentDrag property in Handler.Box class.
• Sometimes not detected "mouseout" (dragging vertices using Control.ModifyFeature). Try out the map to the top using http://openlayers.org/dev/examples/wfs-snap-split.html, fail enough times in this example ("erilem" and I saw something like using drawing handlers) Pending opening a ticket.

[jorix]

Replying to jorix:

... * Sometimes not detected "mouseout" ... Pending opening a ticket.

After further investigate this anomaly, it has opened the ticket #3399 that descrive this problem and provides a patch.

[ahocevar]

With the mouseout issues described in #3399, it may not be wise to make documentDrag true by default. So this should be solved in a different way.

[ahocevar]

For now, it's best if people who want the pre-2.11 behavior of dragging over map overlays set documentDrag to true on the application level.

[ahocevar]

I'm currently working on a fix for this, which involves removing the eventsDiv and handling button events before all other events are handled.

[erilem]

The eventsDiv was introduced during the mobile code sprint. I can't remember why exactly we introduced it, but we didn't have many options if I recall correctly. Tim might remember this better than me.

[jorix]

Replying to ahocevar:

I'm currently working on a fix for this, which involves removing the eventsDiv and handling button events before all other events are handled.

See #3091

I think it is possible to address the issue without touching the eventsDiv:

Setting documentDrag = true ran aground on #3399. I believe that can be addressed with another strategy: listen only document events after start a drag, so ignore the "mouseout" with problems (only when documentDrag = true).
I can try it in #3399 if you agree.

[ahocevar]

See  https://github.com/openlayers/openlayers/pull/164

[ahocevar]

In with  https://github.com/openlayers/openlayers/commit/07dc1b5d84c9aec742653802fbc25548568fed12.