Ticket #3341 (closed feature: fixed)

Opened 2 years ago

Last modified 20 months ago

remove unneeded destroy and initialize function

Reported by: fredj Owned by: erilem
Priority: trivial Milestone: 2.12 Release
Component: general Version: SVN
Keywords: Cc:
State: Commit

Description

Remove unneeded destroy and initialize function because only the parent class is called.

Tests pass on Chrome.

Attachments

3341.0.patch Download (2.3 KB) - added by fredj 2 years ago.
3341.1.patch Download (11.2 KB) - added by fredj 21 months ago.
remove unneeded destroy and initialize functions

Change History

Changed 2 years ago by fredj

Changed 2 years ago by ahocevar

  • state changed from Review to Commit

Looks safe to commit.

Changed 2 years ago by fredj

  • milestone changed from 2.12 Release to 2.11 Release

Changed 2 years ago by fredj

  • state changed from Commit to Pullup

Changed 22 months ago by ahocevar

  • status changed from new to closed
  • resolution set to fixed

in 2.11-rc2

Changed 21 months ago by fredj

  • status changed from closed to reopened
  • state Pullup deleted
  • resolution fixed deleted
  • milestone changed from 2.11 Release to 2.12 Release

found more unneeded destroy and initialize call, patch to come

Changed 21 months ago by fredj

remove unneeded destroy and initialize functions

Changed 21 months ago by fredj

  • state set to Review

Tests still pass, thanks for any review.

Changed 20 months ago by fredj

  • owner set to erilem
  • status changed from reopened to new

Changed 20 months ago by erilem

  • state changed from Review to Commit

Changed 20 months ago by fredj

  • status changed from new to closed
  • resolution set to fixed

(In [12386]) remove unneeded destroy and initialize function. r=erilem (closes #3341)

Note: See TracTickets for help on using tickets.