Handler.Path: Problem with "modify" callback in drawing parameter.

[jorix]

There is a problem with "modify" callback in drawing parameter using freehand (in down and move methods)

Starting freehand, and continuing in normal mode all the moves before the next point call "modify" callback with the drawing parameter to false.

Try:

• use the example measure.html selecting "use immediate measures"
• start freehand
• release the shift key
• move, oops! the immediate measure does not change.
• continue freehand
• release the shift key
• move, ok! now works

[jorix]

Replying to jorix:

...

missing a step:

• ...
• move, oops! the immediate measure does not change.
• click
• continue freehand
• ...

[pgiraud]

I would not consider this one blocker for 2.11 since the "immediate measure" option was not available in 2.10. Please shout out if you don't agree.

[jorix]

Replying to pgiraud:

I would not consider this one blocker for 2.11 since the "immediate measure" option was not available in 2.10. Please shout out if you don't agree.

The behavior is not consistent. first time not works and the next really works, oops!

To write a patch is very easy using  3323.patch (now rejected by you), only needs to be changed !!this.lastUp by this.drawing in down and move methods. I convinced "crschmidt" using this argument ( 3323#comment:4).

Sorry I did not publish the patch, waiting for the implementation of #3323 (thought I'd have to give less explanation, I was wrong) :-(

You have the last word. I do not touch more this ticket if the OL team does not seem appropriate.

[jorix]

A: using new drawing property

[jorix]

B: using getCurrentPointIndex function

[jorix]

I've looked again this topic:

There is an added difficulty: The use of third argument of modify callback isn't described in the documentation (also not mentioned in the release notes)

I think interesting to add such documentation in 2.11, since it is an improvement that avoids having to use drawing property of the handler (which has disappeared in 2.11)

When addPoint I have retained the undefined value for drawing argument, it is more pactice see use in Control/Measure.js.

To fix the bug, I propose two alternatives:

• A: use the drawing property reintroduced (only for internal use)
• B: use the new getCurrentPointIndex function (I think it will cost a bit more)

In the two options are added detailed documentation and tests of drawing argument of modify callback (only three of new tests fail using the trunk)

NOTE: I have not touched the line 480 of Handler/Path.js but I think it should be this.modifyFeature(evt.xy, !!this.lastUp); I have not changed because currently does not cause problems (that I know)

[bartvde]

After discussion with crschmidt on IRC moving to 2.12

[jorix]

Merged with current trunk

[jorix]

The bug is still active, please review: 3319-A2.patch or 3319-B1.patch . Thanks

[jorix]

Please review:  https://github.com/openlayers/openlayers/pull/314

[jorix]

follow on GitHub